MAGIC Magic Mailing List
 
 

From: R. Timothy Edwards (tim AT stravinsky DOT jhuapl.edu)
Date: Tue Oct 21 2003 - 16:59:05 EDT

  • Next message: Steven M Brown: "Magic extraction challenge"

    Dear Steve,
    
       Line 169 of ResReadSim.c is where the function ResReadSim() calls
    ResSimAttribute.  Yet, the 3rd declared argument to ResSimAttribute
    is an (int *), whereas the call to ResSimAttribute (via the function
    pointer "attrproc") passes "extfile", which is an integer.  Clearly
    the error is that the call in ResReadSim() should be:
    
             case 'A':   if (attrproc) result =
                               (*attrproc)(line[ATTRIBUTENODENAME],
                               line[ATTRIBUTEVALUE],
                               simfile,
                               &extfile); 
    
       Otherwise, you don't get the expected behavior (extfile can only
    be changed from within the routine ResSimAttribute(), which is why
    it's passed as a pointer).
    
       Obviously the resistor label tags aren't used much.  Is that
    documented?  I wrote my own method for handling externally-driven
    nodes in 7.2 when implementing the geometry extraction for inductance
    calculations, and never noticed the handling of the "res:" label
    tags.
    
       I will fix this in versions 7.2 and 7.3, and see if I can upload
    the fix to the 7.1 CVS source database.
    
       Thanks for the detailed report!
    
    					Regards,
    					Tim
    


  •  
     
    Questions? Contact Rajit Manohar
    cornell logo